Clear environment for child Commands
#12901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholderbach
reviewed
May 19, 2024
| @@ -537,6 +537,7 @@ impl ExternalCommand { | |||
| .to_string(); | |||
|
|
|||
| let mut process = std::process::Command::new(head); | |||
| process.env_clear(); | |||
There was a problem hiding this comment.
Not sure if we can completely nuke the environment on Windows:
std::process::Command::env_clearis unusable on Windows rust-lang/rust#114737- test: clear parent envs to prevent leakage to tests #9976 (comment)
Are we modifying the env later before spawning?
There was a problem hiding this comment.
Are we modifying the env later before spawning?
Yep, of course. So if the necessary windows environment variables are present in nushell's emulated env, then the child process will get them. But if a user uses hide-env on one of those special env vars then 🤷
There was a problem hiding this comment.
As this method is pub maybe worth documenting. The only outside use in exec seems to also properly set the environment.
sholderbach
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug when
hide-envis used on environment variables that were present at shell startup. Namely, child processes still inherit the hidden environment variable. This PR fixes #12900, fixes #11495, and fixes #7937.Tests + Formatting
Added a test.