-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show only versions newer than NVM_MIN_VER if set #3277
base: master
Are you sure you want to change the base?
Conversation
a81e16a
to
b10554a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that it's done in awk :-) it'd be great to benchmark the difference to make sure this isn't slowing anything down meaningfully.
this will need tests, and also it'd be good to add a --min
option to all the things that talk to the mirror (nvm ls-remote
, nvm install
, nvm version-remote
) and then maybe nvm ls
for good measure (altho that can be a follow-on if you like)
Performance-wise there's not really much change or overhead, you can trust that awk is fast :-) Sometimes it might even run faster, esp. when many older versions are skipped. Meanwhile the other sibling functions and even the tests are something I'm not really familiar with, may you can chime in here? @ljharb |
Sure - for the tests, there's existing tests for For adding an option, if you grep for |
This is to fix #3250.