Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Performance - implement multi thread mechanism #105

Open
odedshimon opened this issue Sep 3, 2021 · 12 comments
Open

Improve Performance - implement multi thread mechanism #105

odedshimon opened this issue Sep 3, 2021 · 12 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@odedshimon
Copy link
Owner

Improve BruteShark performance by refactor the BLL layer (aka PcapAnalyzer project to use multi thread mechanism).
That includes:

  • Design the solution and discuss about it with me.
  • Implement it.
  • Writing tests that will test exactly this mechanism.
@odedshimon odedshimon added the help wanted Extra attention is needed label Sep 3, 2021
@odedshimon odedshimon added the good first issue Good for newcomers label Oct 9, 2021
@neolace
Copy link

neolace commented Jan 27, 2022

@odedshimon Can I help with this?

@odedshimon
Copy link
Owner Author

Hi @neolace!
You are welcome, feel free to consult with me on anything

@neolace
Copy link

neolace commented Jan 28, 2022

Hi @odedshimon!
Awesome, let me check the code first, then I'll get back to you wrt design, implementation and tests as outlined above.
Could you assign this one to me?

@odedshimon odedshimon assigned odedshimon and neolace and unassigned odedshimon Jan 28, 2022
@odedshimon
Copy link
Owner Author

Done, sounds great.

@neolace
Copy link

neolace commented Jan 28, 2022

Hi @odedshimon,

I'm using Rider from JetBrains, it states that the author is unknown on every method, is this expected?

I don't see comments, not that I'm a fan, but do you want me to add comments or stay with the flow?

@odedshimon
Copy link
Owner Author

@neolace
Thats not a problem.
Regard to comments I ussualy document only critical / unclear code sections, feel free do document as you like.

@neolace
Copy link

neolace commented Jan 30, 2022

@odedshimon
Cool, thank you.

May I create an issue from this thread?

@odedshimon
Copy link
Owner Author

@neolace
Not sure I understand, this is already an issue

@neolace
Copy link

neolace commented Feb 1, 2022

@odedshimon
What was I thinking, you're right of course.

Is there a specific sub project or section of the code that you would like me to takle first?

Which branch should I use to apply changes wrt to this issue? Pull request etc

@odedshimon
Copy link
Owner Author

  1. I whould start from PcapAnalyzer project, each task can run independently, therfore it is a sutable section for multi-threading.
  2. You can send Pull Requests to master branch, I will merge it after code review and testing. You can create local branch as you like at your fork.

@neolace
Copy link

neolace commented May 23, 2022

@odedshimon
Apologies for the delay, I was swamped. On this now.

@RobbeBryssinck
Copy link

@neolace
Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants