Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueError when attempting to calculate refundable amount for multiple payments #165537

Closed
flexadecimal opened this issue May 14, 2024 · 1 comment
Closed

ValueError when attempting to calculate refundable amount for multiple payments #165537

flexadecimal opened this issue May 14, 2024 · 1 comment
Labels
Payment Payment providers

Comments

@flexadecimal
Copy link

odoo/addons/payment/models/account_payment.py

Line 54 in c7d420b

refund_payments = self.search([('source_payment_id', '=', self.id)])

RecordSet usage error - should be payment.id in domain used for search.
vava-odoo added a commit to odoo-dev/odoo that referenced this issue May 17, 2024
@vava-odoo
[FIX] payment: fix singleton issue in search
565cdfe 
If you try to retrieve the `amout_available_for_refund` of a recordset
of `account.payment`, it raises a traceback because the search domain
includes `self.id` where it should be on the record `payment`.

Fixes odoo#165537
@vava-odoo vava-odoo mentioned this issue May 17, 2024
Closed
@vava-odoo vava-odoo added Payment Payment providers labels May 17, 2024
@AntoineVDV AntoineVDV linked a pull request May 21, 2024 that will close this issue
[FIX] payment: fix singleton issue in search #165945
Closed
This was referenced May 21, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@vava-odoo
Copy link
Contributor

Hi @flexadecimal
Thanks for reporting. Issue was fixed with referenced PR.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Payment Payment providers
Projects
None yet
Milestone
No milestone
2 participants
@flexadecimal @vava-odoo