Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure test layer is in the build DAG #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ensure test layer is in the build DAG #73

wants to merge 1 commit into from

Conversation

LucasRoesler
Copy link
Member

Some builders will exclude layers that do not contribute to the final target layer, meaning the ship layer for these templates. This means that the test layer is often optimized away by modern builders.

We add the test layer as a dependency of the ship layer to ensure it is always run.

Motivation and Context

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label

Resolves #71

How Has This Been Tested?

Yes, running docker build will now show the test layer in the output. This was also documented in the issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@LucasRoesler
fix: ensure test layer is in the build DAG
a091502 
Some builders will exclude layers that do not contribute to the final
target layer, meaning the `ship` layer for these templates. This means
that the `test` layer is often optimized away by modern builders.

We add the `test` layer as a dependency of the `ship` layer to ensure it
is always run.

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
@LucasRoesler LucasRoesler mentioned this pull request Feb 6, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python function test
1 participant
@LucasRoesler