openssl/3.2.1 dgram support for for QNX

[klausholstjacobsen]

I know that official support for QNX was removed in 2018.
I have however been building OpenSSL for qnx successfully until now.

In 3.2.x I am however seeing errors:

crypto/bio/bss_dgram.c: In function 'pack_local':
crypto/bio/bss_dgram.c:1178:13: error: 'struct in_pktinfo' has no member named 'ipi_spec_dst'
         info->ipi_spec_dst      = local->s_in.sin_addr;

Would it be ok to add a PR with __QNX__ among the ifdefs in crypto/bio/bs_dgram.c:1177 so that:

#   if !defined(OPENSSL_SYS_WINDOWS) && !defined(OPENSSL_SYS_CYGWIN)
        info->ipi_spec_dst      = local->s_in.sin_addr;
#   endif

...becomes...

#   if !defined(OPENSSL_SYS_WINDOWS) && !defined(OPENSSL_SYS_CYGWIN) && !defined(__QNX__)
        info->ipi_spec_dst      = local->s_in.sin_addr;
#   endif

or is any reference to QNX not allowed?

Regards
Klaus

[tom-cosgrove-arm]

Looking at the PR (5756) that removed the support, the reason given was "cannot find contributors to get their approval for the license change", and @mattcaswell (still on the OTC and OMC) stated

In the event that someone later re-contributes QNX support I think we should accept it as a "bug" fix

so it seems extremely likely that such a small PR would be accepted. So please: raise that as a PR.

[mattcaswell]

Our platform policy says this:

Support for a new platform should only be added if it is being adopted as a primary, secondary or community platform.

https://www.openssl.org/policies/general/platform-policy.html

A community platform is described like this:

Definition: Platforms that one or more members of the OpenSSL community have volunteered to support. May or may not be in project CI. Members of the community providing support do not have to be committers.

So in order re-add support for QNX it would have to become a community platform, which would need someone to volunteer to support it on an ongoing basis. That can be done by creating a PR against the general-policies repo, like this recent example:

openssl/general-policies#66