-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overrides not working with parametrized default #20933
Labels
Comments
I nailed it down to this: isra17@1cc132b
|
Excellent find! I'd just like to point out that this is a address issue, the actual resolve is correct:
|
kaos
pushed a commit
that referenced
this issue
May 28, 2024
This fix a bug where default parametrize resolve could not get overriden. The fix ensure that an address parameters are updated on any override, not just parametrized one. Fixes #20933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I took the time to create an example off the example python repo. See here:
After this patch, I would expect both
helloworld/translator/translator.py
andhelloworld/translator/__init__.py
to be only inpython-other
resolve.However I get the following result:
Note that not using
parametrize
in the__defaults__
also make this work.Pants version
Which version of Pants are you using?
2.20.0
The text was updated successfully, but these errors were encountered: