Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Base58 (P2SH-SegWit)" address generation in UI and do not show them in minting tab #699

Open
MatthewLM opened this issue Jun 22, 2023 · 0 comments

Comments

@MatthewLM
Copy link
Contributor

In the receive tab, there are options for "Base58 (Legacy)", "Base58 (P2SH-SegWit)" and "Bech32 (SegWit)". The P2SH_SEGWIT outputs are not used by the client minting code. Therefore they should be removed as an option in src/qt/receivecoinsdialog.cpp. These outputs should also not be included in the minting tab as they cannot be minted by the client code.

Also consideration should be had about the tooltips. The base58 P2PKH (LEGACY) option currently has the message "Not recommended due to higher fees and less protection against typos.".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant