Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Enhancement #1244

Open
VaibhavSharma24 opened this issue Sep 28, 2023 · 8 comments
Open

Design Enhancement #1244

VaibhavSharma24 opened this issue Sep 28, 2023 · 8 comments

Comments

@VaibhavSharma24
Copy link

I want to add some attractive Navbar and Footer on this website which will enhance the overall experience

@SUJALWEB
Copy link

SUJALWEB commented Oct 2, 2023

hey, I want to controbute in this issue

@tsatke
Copy link

tsatke commented Oct 3, 2023

I think the best way to continue here is to just provide a PR with the changes, preferably with screenshots if there are changes to the ui.

@VaibhavSharma24
Copy link
Author

Sure i am on it

@phil-opp
Copy link
Owner

phil-opp commented Oct 4, 2023

Could you clarify what kind of navbar/footer you imagine? Are there any usability issues that you like to fix or is this only about changing the design?

@VaibhavSharma24
Copy link
Author

VaibhavSharma24 commented Oct 27, 2023

I am thinking of a minimalist sticky header on top with these heading -> Writing an OS in Rust Philipp Oppermann's blog and a Footer with © 2022. All rights reserved. [License][Contact]

The main advantage is while loading your code the web browser knows the header and footer portion. It helps in prioritizing on the things to be loaded first and make the content on webpage easy to read for the audience.

Please feel free to tell me what you think of this @phil-opp

@phil-opp
Copy link
Owner

I'm not a fan of sticky headers or footers since they reduce the space available for content, especially on mobile.

To try this out, I added position: sticky; top/bottom:0; background-color: white; to the header/footer elements as a test.

With sticky header and footer

This is how the page would look like on a landscape mobile screen with a sticky header and footer:

image

With current design

Without the sticky headers, you see much more content:

image

@VaibhavSharma24
Copy link
Author

I understand @phil-opp so to keep the content more spaced we can do one more thing we can add a simple header and footer which doesn't stick as you scroll down what do you think ?

@VaibhavSharma24
Copy link
Author

Recording.2023-10-28.163158.mp4

Something Like This ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants