Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNPM consider Turborepo packages as npm packages #8091

Open
3 of 4 tasks
jpmadrigal07 opened this issue May 16, 2024 · 2 comments
Open
3 of 4 tasks

PNPM consider Turborepo packages as npm packages #8091

jpmadrigal07 opened this issue May 16, 2024 · 2 comments

Comments

@jpmadrigal07
Copy link

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

9.0.1

Which area(s) of pnpm are affected? (leave empty if unsure)

CLI

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

  1. Make sure you have installed pnpm@9.0.1
  2. Make sure you have a Vercel's Turborepo project that built using pnpm
  3. Add custom package that can be installed in apps folder
    image
    image
  4. Then try to run pnpm install and you will get this error
    image

Describe the Bug

The bug occurs when you are using pnpm 9, it considers all custom packages for Turborepo as an actual npm packages. I need to go back to pnpm 8 in order to fix the error.

Expected Behavior

The pnpm 9 should not consider it as a npm packages, instead need to look at the packages folder also.

Which Node.js version are you using?

20.10.0

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response

@weyert
Copy link
Contributor

weyert commented May 16, 2024

Aren't you supposed to use workspace:* instead of *?

You might have been relying on the link-workspace-packages being enabled by default in v8 but is disabled in v9. Try adding link-workspace-packages=true to your .npmrc-file.

@ocavue
Copy link

ocavue commented May 17, 2024

Aren't you supposed to use workspace:* instead of *?

Some third-party tools don't recognize PNPM's workspace:* version syntax, so I'm trying to not use workspace:*.

You might have been relying on the link-workspace-packages being enabled by default in v8 but is disabled in v9.

I tried to set link-workspace-packages=true in .npmrc but it still doesn't work.


I've created another issue on the turborepo side (vercel/turbo#8168), where you can find detailed reproduction steps. I'm not sure whether this is a PNPM bug or a turborepo bug, so I left my comment here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants