Aquire lock before calling getTunnelDetails #11788
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Logically it si reasoned to fix the linked issue, but feedback on this PR is much appreciated.
Tries to closes #11787
Changes:
As per note above
getTunnelDetails
, a lock must be aquired before calling the method. InSetTunnelStatusToRequired
this does not happen, and can potentially cause #11787. This PR reorders the the calls to precent the method being called without the lock