Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *kwargs to pass extra parameter to LGBMModel fit #45

Open
antoniocastelli1 opened this issue Oct 20, 2023 · 0 comments
Open

Add *kwargs to pass extra parameter to LGBMModel fit #45

antoniocastelli1 opened this issue Oct 20, 2023 · 0 comments

Comments

@antoniocastelli1
Copy link

Dear PoweShap authors,

I am Antonio, Machine Learning Scientist @ Booking.com.
We found this package quite nice and useful. I have a question over the code:

PowerShap_model.fit(X_train, Y_train, eval_set=(X_val, Y_val))

In this line the **kwargs are not passed to the fit method of LGBMModel. Since they are not passed it's not possible to set extra parameter to the fit method.
This means that the **kwargs and **fit_kwargs specified in PowerShap class initialization are not used.

Could you please check and maybe fix this in a new release.

Cheers

Antonio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant