fix(plugin install): copy executable by renaming instead of create file #123

c84c · 2022-05-17T12:40:35Z

Implements

Discussion

During refactoring on commit change plugin build mechanism the new flogo executable is created instead of renamed.

Linux system not allows to update a running executable resulting in error text file busy.

The PR insert a SwapFile function to allow replacement of running executable (Thanks to @fenollp and his gist)

Code references

Old renaming implementation on commits before change plugin build mechanism :

cli/commands/plugin.go

Line 267 in 22cf3e3

err = os.Rename(filepath.Join(cliCmdPath, cliExe), exe)

Actual implementation on master:
Executable copy:

cli/commands/pluginhelper.go

Line 108 in 5c3e1e3

err = util.Copy(filepath.Join(cliCmdPath, cliExe), exPath, false)

copyFile function

cli/util/file.go

Lines 131 to 143 in 5c3e1e3

    
           var df *os.File 
        
           if df, err = os.Create(dst); err != nil { 
        
           	return err 
        
           } 
        
           defer df.Close() 
        
           if err = os.Chmod(sf.Name(), srcInfo.Mode()); err != nil { 
        
           	return err 
        
           } 
        
           if _, err = io.Copy(df, sf); err != nil { 
        
           	return err 
        
           }

…instead of copy/create

c84c · 2022-07-08T14:37:58Z

Have you planned when to merge the Pull Request?

fix(plugin install): copy executable by renaming and swap executable …

6460802

…instead of copy/create

mellistibco approved these changes May 17, 2022

View reviewed changes

mellistibco requested a review from vijaynalawade May 17, 2022 14:33

vijaynalawade approved these changes Jun 6, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(plugin install): copy executable by renaming instead of create file #123

fix(plugin install): copy executable by renaming instead of create file #123

c84c commented May 17, 2022

c84c commented Jul 8, 2022

	var df *os.File
	if df, err = os.Create(dst); err != nil {
	return err
	}
	defer df.Close()

	if err = os.Chmod(sf.Name(), srcInfo.Mode()); err != nil {
	return err
	}

	if _, err = io.Copy(df, sf); err != nil {
	return err
	}

fix(plugin install): copy executable by renaming instead of create file #123

Are you sure you want to change the base?

fix(plugin install): copy executable by renaming instead of create file #123

Conversation

c84c commented May 17, 2022

Implements

Discussion

Code references

c84c commented Jul 8, 2022