Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting an additional framework: CIS AWS Compute Services Benchmark v1.0.0 #2644

Open
Jawand-a opened this issue Jul 31, 2023 · 4 comments
Assignees
Labels
feature-request New feature request for Prowler. help wanted new check idea provider/aws Issues/PRs related with the AWS provider severity/low Bug won't result in any noticeable breakdown of the execution.

Comments

@Jawand-a
Copy link

Jawand-a commented Jul 31, 2023

New feature motivation

We would like to use Prowler for AWS compliance but Prowler doesn't include all of the relevant frameworks, specifically CIS AWS Compute Services Benchmark v1.0.0.

Solution Proposed

Adding the CIS AWS Compute Services Benchmark v1.0.0 to Prowler AWS compliance.
CIS_AWS_Compute_Services_Benchmark_v1.0.0.pdf

Describe alternatives you've considered

Prowler offers CIS AWS foundations in version 1.4, 1.5, and 2.0 but doesn't include the computer services benchmark.

Additional context

This CIS benchmark was released in April, found at https://www.cisecurity.org/insights/blog/cis-benchmarks-april-2023-update#NewCISAWSComputeServicesBenchmarkv1.0.0

@Jawand-a Jawand-a added feature-request New feature request for Prowler. status/needs-triage Issue pending triage labels Jul 31, 2023
@toniblyx
Copy link
Member

toniblyx commented Aug 1, 2023

Thanks for asking @Jawand-Appian, as you can see below, we cover some of the checks already (14 checks), however others need to be written (38 checks). To be honest it is the first time we have been asked for this CIS Benchmark and considering it is v1 and v1.1 is coming up, let´s see if it really makes sense to cover all of them. In any case feel free to contribute with any check that you need and we can help you bulding the compliance json if needed like in prowler/compliance/aws/cis_2.0_aws.json
Screenshot 2023-08-01 at 18 03 40

here is the excel if you want to work on it
CIS_AWS_Compute_Services_Benchmark_v1.0.0.xlsx

@Jawand-a
Copy link
Author

Jawand-a commented Aug 1, 2023

@toniblyx thank you for your response/insight. Quick questions:

  1. Some of the benchmarks available on Prowler like "Ensure Secrets and Sensitive Data are not stored directly in EC2 User Data" I see under services, others like "Ensure an Organizational EC2 Tag Policy has been Created" I'm not able to find (maybe it's named differently). Is there a way to find checks already implemented in prowler?
  2. Is there documentation on what information a check has? I see a developer guide on creating a new check/security compliance framework but not on actually developing the check itself.

@toniblyx
Copy link
Member

toniblyx commented Aug 3, 2023

  1. [ec2_instance_secrets_user_data] Find secrets in EC2 User Data. - ec2 [critical] and
    [organizations_tags_policies_enabled_and_attached] Check if an AWS Organization has tags policies enabled and attached. - organizations [medium]
    you can use prowler <provider> -l to list all available checks on each provider (aws, gcp, azure).

  2. Best place to get information about what a check does is on each check metadata.json file. In the devel guide you have instructions on how to create a check, see here.

@toniblyx
Copy link
Member

toniblyx commented Aug 3, 2023

Remember that for Prowler every compliance framework (CIS, PCI, NIST, etc.) is a list of specific and special requirements that can be automated or manual so, one CIS requirement maps usually with one Prowler check, but not in all cases. If the requirement is manual doesn't map with any check and in some cases a requirement maps with multiple checks.

@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Aug 4, 2023
@toniblyx toniblyx added help wanted new check idea severity/low Bug won't result in any noticeable breakdown of the execution. and removed status/needs-triage Issue pending triage labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request for Prowler. help wanted new check idea provider/aws Issues/PRs related with the AWS provider severity/low Bug won't result in any noticeable breakdown of the execution.
Projects
None yet
Development

No branches or pull requests

3 participants