chore(mutelist): Exclude resources from AFT #3956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
force-pushed
the
PRWLR-3666-bug-check-failing-due-to-iam-roles-created-by-aws-control-tower-and-aft-with-administrator-access-policy-3810
branch
from
9c2a8b5
to
fdb975a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3956 +/- ##
==========================================
+ Coverage 86.32% 86.37% +0.05%
==========================================
Files 748 748
Lines 23333 23333
==========================================
+ Hits 20142 20154 +12
+ Misses 3191 3179 -12 ☔ View full report in Codecov by Sentry. |
sergargar
requested changes
May 7, 2024
You are right 🤦, I'm going to close the PR and let the customer know that our mutelist currently supports that. Thanks for the catch. |
|
Already included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3810
Description
Exclude more resources from AWS Control Tower and AFT (Account Factory for Terraform) in the AWS mutelist.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.