-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow alternative schemes in Binder #3348
base: master
Are you sure you want to change the base?
Conversation
9e61153
to
e9353b6
Compare
It would be good to document / show how one can use this (it is not entirely clear to me, even when I've read the linked issue, but I have also never developed a plugin for Puma) Can something be added to https://github.com/puma/puma/blob/master/docs/plugins.md? |
I've added some documentation. I also didn't develop any plugins. I don't know how to write an example. I could maybe add that link for context and add how that change would make difference for acme-puma codebase? (change of the method name, and removal of Does that sound right? |
7c862e5
to
e829dd1
Compare
I think that would be good |
e829dd1
to
49785dc
Compare
88b1f58
to
edaf98a
Compare
Description
Allows for adding
before_parse
hooks to theBinder#parse
method.Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.Closes #3302