-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying audio context that manual lookup can associate with #136
Comments
(responding to #133 (comment))
Yes. This is actually what I tested OCR with.
You are totally correct. I realized I am actually more envisioning this for manual lookup. Because Memento currently sends OCR results to lookup I decided to talk about them together. My imagined main use case actually pertains to consuming content that does not have subtitles at all. I have encountered the following two scenarios:
I agree that in cases where visual context is detached from audio context this does not work. Perhaps I'll be having multiple profiles for lookup w/ context, lookup w/o context, etc. I want to know what you think. |
Now that I understand the use case for this feature, my next concern is how to explain it to the user. My philosophy when designing Memento has been to try and keep everything as self explanatory as possible. I don't want Memento to become a piece of software you need a guide to use.
In this case |
I think this makes enough sense.
I think a number of video players including mpv support setting some kind of A-B loop (default keybind
though I agree it is not always the most intuitive feature. I think providing a new marker like |
I'm satisfied with this. I'm not sure when I'll get this done, but I have enough to go off of now. |
(moved from #133)
Currently Memento does not seem to support associating an OCR (or manual lookup) result with a certain stretch of audio in the absence of a subtitle file, which feels like neglecting Memento's most important feature.
I think it would be great if Memento allows the user to choose a part of the current video as the current context. Some DWIM behavior I imagine is:
Also this might not be possible, but I wonder if Memento could use the timing information from
sub-seek
to determine the current{sentence}
. This feels inflexible and might be expensive, so I don't really know.The text was updated successfully, but these errors were encountered: