Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbox image value causes chart to fail #14181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sammcgeown
Copy link

Currently the toolbox image sets no value - either toolbox.image needs to be unset to default to the ceph value or the value should not be commented. I've commented the whole line here as the template shows this is the desired behaviour:

      image: {{ default .Values.cephClusterSpec.cephVersion.image .Values.toolbox.image }}

Issue resolved by this Pull Request:
Resolves #14180

Checklist:

  • [ x] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • [x ] Reviewed the developer guide on Submitting a Pull Request
  • [ x] Pending release notes updated with breaking and/or notable changes for the next minor release.
  • [x ] Documentation has been updated, if necessary.
  • [ x] Unit tests have been added, if necessary.
  • [ x] Integration tests have been added, if necessary.

Currently the toolbox image sets no value - either toolbox.image needs to be unset to default to the ceph value (which I think is the desired operation) or the value should not be commented. I've commented the whole line here.
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion in #14180, I'm not seeing why this is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rook Ceph Cluster helm chart toolbox image value broken by default
2 participants