Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing images is failing since updating the CI to Ubuntu 22.04 #14208

Closed
travisn opened this issue May 14, 2024 · 2 comments · Fixed by #14214 or #14221
Closed

Publishing images is failing since updating the CI to Ubuntu 22.04 #14208

travisn opened this issue May 14, 2024 · 2 comments · Fixed by #14214 or #14221
Assignees
Labels
Projects

Comments

@travisn
Copy link
Member

travisn commented May 14, 2024

Is this a bug report or feature request?

  • Bug Report

Deviation from expected behavior:
The publish images CI is failing in master and 1.14 branches since #14166 was merged to update the CI to Ubuntu 22.04.
See the history of the CI failures.

The logs of a failed job show:

=== installing manifest-tool
mkdir -p /home/runner/work/rook/rook/.cache/tools/linux_amd64
curl -sL https://github.com/estesp/manifest-tool/releases/download/v1.0.2/manifest-tool-linux-amd64 > /home/runner/work/rook/rook/.cache/tools/linux_amd64/manifest-tool-v1.0.2
chmod +x /home/runner/work/rook/rook/.cache/tools/linux_amd64/manifest-tool-v1.0.2
      Successfully remade target file '/home/runner/work/rook/rook/.cache/tools/linux_amd64/manifest-tool-v1.0.2'.
     Finished prerequisites of target file 'publish.manifest.image.ceph'.
    Must remake target 'publish.manifest.image.ceph'.
/home/runner/work/rook/rook/.cache/tools/linux_amd64/manifest-tool-v1.0.2 push from-args --platforms linux/amd64 linux/arm64, --template rook/ceph-ARCH:v1.14.0.115.g517b1bf12 --target rook/ceph:v1.14.0.115.g517b1bf12
time="2024-05-07T15:14:02Z" level=fatal msg="You must specify all three arguments --platforms, --template and --target"
make: *** [Makefile:192: publish.manifest.image.ceph] Error 1
make: Leaving directory '/home/runner/work/rook/rook/build/release'
Error: Process completed with exit code 2.

Perhaps the argument is getting confused, since the "ARCH" param is not getting evaluated in that command:

--template rook/ceph-ARCH:v1.14.0.115.g517b1bf12

Expected behavior:
Publish images CI should pass

How to reproduce it (minimal and precise):

Merge to master or 1.14 branches and see the failure.

@travisn travisn added the bug label May 14, 2024
@travisn travisn added this to To do in v1.14 via automation May 14, 2024
@travisn travisn moved this from To do to Blocking Release in v1.14 May 14, 2024
@subhamkrai
Copy link
Contributor

I have found the issue

--platforms linux/amd64 linux/arm64,

instead, it should be

--platforms linux/amd64, linux/arm64

here

 /home/runner/work/rook/rook/.cache/tools/linux_amd64/manifest-tool-v1.0.2 push from-args --platforms linux/amd64 linux/arm64, --template rook/ceph-ARCH:v1.14.0.115.g517b1bf12 --target rook/ceph:v1.14.0.115.g517b1bf12

v1.14 automation moved this from Blocking Release to Done May 15, 2024
@travisn
Copy link
Member Author

travisn commented May 15, 2024

Looks like still an error for --platforms in the latest push.

/home/runner/work/rook/rook/.cache/tools/linux_amd64/manifest-tool-v1.0.2 push from-args --platforms linux/amd64,linux/arm64, --template rook/ceph-ARCH:v1.14.0.131.gfd7137bb4 --target rook/ceph:v1.14.0.131.gfd7137bb4
time="2024-05-15T16:55:34Z" level=fatal msg="The --platforms argument must be a string slice where one value is of the form 'os/arch'"

@travisn travisn reopened this May 15, 2024
v1.14 automation moved this from Done to In progress May 15, 2024
v1.14 automation moved this from In progress to Done May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
v1.14
Done
2 participants