Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutating Ops #73

Open
FintanH opened this issue Apr 9, 2020 · 1 comment
Open

Mutating Ops #73

FintanH opened this issue Apr 9, 2020 · 1 comment

Comments

@FintanH
Copy link
Contributor

FintanH commented Apr 9, 2020

As discussed in #72 it can be perceived as weird by users that a function such as Orswot::add does not actually add to the underlying set.

For example, if I were to call add followed by read the addition would not be seen on my side. One idea would be to have another function called apply_add that mutates the underlying set as well as outputting the Op to write to a log/broadcast the changes.

@dan-da
Copy link

dan-da commented Jan 12, 2021

or perhaps just rename Orswot::add to Orswot::mk_add_op() or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants