Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save chi2 values to results #202

Open
semaphoreP opened this issue Jan 22, 2021 · 2 comments
Open

save chi2 values to results #202

semaphoreP opened this issue Jan 22, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers long term Probably won't be addressed any time soon.

Comments

@semaphoreP
Copy link
Collaborator

semaphoreP commented Jan 22, 2021 •
edited

Eric Nielsen thinks this is useful to save sometimes. We would need to modify our likelihood to get this value back.
@semaphoreP semaphoreP added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2021
@sblunt sblunt added this to the v2.0 milestone Aug 11, 2021
@sblunt sblunt removed this from the v2.0 milestone Aug 25, 2021
@sblunt
Copy link
Owner

sblunt commented Oct 8, 2021

Hm, we save lnlike right now, shouldn't we just need to multiply to get chi2?

@sblunt
Copy link
Owner

sblunt commented Oct 11, 2021

Just kidding, I'm wrong about that since we now subtract off log(sqrt(error^2)) ever since adding in jitter as a free parameter.

@semaphoreP semaphoreP added the long term Probably won't be addressed any time soon. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers long term Probably won't be addressed any time soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@semaphoreP @sblunt