Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 7- and 9-parameter Hipparcos fits #320

Open
sblunt opened this issue May 13, 2022 · 1 comment
Open

Handle 7- and 9-parameter Hipparcos fits #320

sblunt opened this issue May 13, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed long term Probably won't be addressed any time soon.

Comments

@sblunt
Copy link
Owner

sblunt commented May 13, 2022

This should be straightforward. We just need to modify the Nielsen test to assess the IAD.

@sblunt
Copy link
Owner Author

sblunt commented May 13, 2022

Eric says:

7- and 9-parameter fits are actually trivial to fit with the existing orbitize code: even though the fit on the Hipparcos DVD gives 7 or 9 parameters for these binaries, the residuals are still reported only to the basic 5 parameters (ignoring the t^2 and t^3 terms). So the embarrassingly-named “Nielsen test” will fail unless it’s editted to do the refit with 7 parameters, but the orbit-fitting should work just fine. The only change needed will be to disable the test that stops the code if a solution type other than “5" is detected.

(Solution types “o” (orbit) and “stochastic” (extra noise added to the scan errors) still need special handling, but save that battle for another day)

@sblunt sblunt added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 13, 2022
@semaphoreP semaphoreP added the long term Probably won't be addressed any time soon. label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed long term Probably won't be addressed any time soon.
Projects
None yet
Development

No branches or pull requests

3 participants