Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Winter Values #3638

Open
2 tasks done
CousinThrockmorton opened this issue May 2, 2024 · 3 comments
Open
2 tasks done

ENH: Winter Values #3638

CousinThrockmorton opened this issue May 2, 2024 · 3 comments
Labels
enhancement Indicates new feature requests

Comments

@CousinThrockmorton
Copy link

Problem Description

Hi,

I hope to extend SHAP to calculate feature contributions for coalitions of features Owen and Winter values. Having reviewed the Partition Explainer and Permutation Explainer code I am not aware of any current package or method that allows users to calculate these values with context specific coalition structures.

Alternative Solutions

The PartitionExplainer method does provide an approximation of Shapley values by using different hierarchical clustering methods (as default). I aim to use that method as a template to develop this which can take an arbitrary user described nested hierarchy of feature coalitions.

Additional Context

I had seen some interest in providing explanations using shapley values in context where it is reasonable to group features in cases such as of high dimensional data, graph, or multi-modal data. Such as this issue and papers such as Rozemberczki et. al (2022) and Mora et. al (2024). One solution for this is the Winter values as described in Winter (1989) which extends the Owen value to hierarchies of nested coalitions dubbed levels structures. Essentially this is done by a recursive call of the Owen values, those marginal average effects respecting the coalitions structure, through the hierarchical tree of coalitions.

Feature request checklist

  • I have checked the issue tracker for duplicate issues.
  • I'd be interested in making a PR to implement this feature
@CousinThrockmorton CousinThrockmorton added the enhancement Indicates new feature requests label May 2, 2024
@CloseChoice
Copy link
Collaborator

Thanks for your interest in shap. This sounds interesting and is indeed an useful feature for this library. If we can support you in any way, don't shy away from asking.

@CousinThrockmorton
Copy link
Author

Hey. Thanks for the support. I added you to the fork created. I am currently working in the shap\notebooks\Rewriting notebook. If you have any tips or guidelines on code structure to aid review or merging I would appreciate that.

@CloseChoice
Copy link
Collaborator

CloseChoice commented May 14, 2024

Thanks for adding me. Would be great if you could create a PR, so that we can discuss specific points in the code once you feel you are ready for that or if you are stuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

2 participants