fix: only clear timeout if the ongoingSelection is not empty #274
Conversation
I always appreciate PR-s and bug reports to improve linguacafe. The changes in the PR remove intended functionality: there should be half a second wait time after touching before the user can select multiple words. I did this because on multiple phones there is a vibration when you keep touching something and don't move your finger. And recently, I thought about adding a hover vocabulary box functionality for tapping a word quickly on touch devices. Based on your description, does this commit fix the problem for you with apple pencils? Now if the updateSelectionTouchEvent gets called during the 0.5s wait on the same word as the one you started the selection with, nothing will happen. It will only get canceled if you move the pencil enough start scrolling, or you move the pencil outside of the word. (This is part 2 of a previous commit.) |
|
It was confirmed on discord that it is working. |
Closes: #262
Sorry for another one line PR.
It seems that for Apple Pencil touch events the updateSelectionTouchEvent function is called right away after the startSelectionTouchEvent, meaning that the function inside the touchTimer setTimeout never executes due to clearTimeout.
This leaves the ongoingSelection array empty meaning that the updateSelection is never called due to this if:
This PR fixes it by only calling the clearTimeout if the this.touchTimer exists and the ongoingSelection is not empty