Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When vst3sdk is a submodule, example plugins are not built - a switch to choose would be very useful #94

Open
IliasBergstrom opened this issue Oct 6, 2022 · 1 comment

Comments

@IliasBergstrom
Copy link

IliasBergstrom commented Oct 6, 2022

We include vst3sdk as a submodule in our project, but want to also build the example plugins - those are very convenient to use in our subsequent unit tests, examples in the repo, etc.

BUT, the below in your CMakeLists.txt disallows that:

if(NOT ${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_CURRENT_LIST_DIR}) message(STATUS "[SMTG] Disable all VST3 samples") set(SMTG_ADD_VST3_PLUGINS_SAMPLES OFF) set(SMTG_ADD_VST3_HOSTING_SAMPLES OFF) set(SMTG_ADD_MYPLUGINS_SRC_PATH OFF) else() set(SMTG_ADD_MYPLUGINS_SRC_PATH ON) endif()

It would be fantastic to have an option we could set in the enclosing project's CMakeLists.txt, where we can turn this circumvention off, and still get the plugins to build!

Thank you.

@IliasBergstrom IliasBergstrom changed the title When vst3sdk is a submodule, example plugins are not built - I would love for this to be optional When vst3sdk is a submodule, example plugins are not built - a switch to choose would be very useful Oct 7, 2022
@IliasBergstrom
Copy link
Author

IliasBergstrom commented Oct 10, 2022

In addition, it'd also be very useful if the VST3 example plugins, were not placed in VST3/Debug/, or VST3/Release/, since that complicates accessing them automatically with paths relative to the main build location.

Since the containing build is either Release or Debug anyway, the placement in explicit build-type subfolders is superfluous, and just VST3/ would suffice, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant