%DOCUMENTS% on windows

[baconpaul]

Right now our user data path search looks like

look for SurgeXTUserData
then do a known folder on FOLDERID_Documents
else throw a pile of errors

Here's what I think it should be, in pseudo-code

std::vector<fs::path> locationsInOrder;

(current find-surge-xt-user-data code)
if (portable dir exists and is a directory)
   locationsInOrder-push_back(surge xt user data);

try
{
   locationsInOrder.push_back(DocumentsTolder)
}
catch {}

try
{
locationsInOrder.push_back(knownFolder(FOLDERID_LocalAppData) / SurgeXT)
}
catch {}

if (locaionsInOrder.empty())
{
   userDataPath = "/not/set"; reportError();
}
else
{
   for (const auto &l : locationsInOrder)
   {
     if (fs::is_directory(l / "Patches")
     {
        // already set up
        userDatPath = l; break;
     }
  }
  if (userDataPath.empty()) userDataPath = locationsInOrder.front();
}

[mkruselj]

Done for XT 1.3.2.