Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The virtual keyboard causes the notes E and F to be triggered #7604

Open
eigenvoid opened this issue Apr 10, 2024 · 7 comments
Open

The virtual keyboard causes the notes E and F to be triggered #7604

eigenvoid opened this issue Apr 10, 2024 · 7 comments
Labels
Bug Report Item submitted using the Bug Report template

Comments

@eigenvoid
Copy link

eigenvoid commented Apr 10, 2024

Bug Description:
When the virtual keyboard is enabled, sometimes the notes E and F play and remain triggered until I press stop in the DAW transport.

Surge XT Version

  • Version: Surge XT 1.3.1.4b53827
  • Plugin Type: VST3, CLAP, standalone
  • Bitness: 64-bit

Reproduction Steps:
Steps to reproduce the behavior:

  1. Open Surge XT with the virtual keyboard on
  2. Click on the Surge window to make sure it's fully focused
  3. Play any note with the computer keyboard
  4. E and F will also be triggered, at the same octave as Surge is currently set to

Expected Behavior:
No unwanted notes should play.

Screenshots:
Screenshot_20240410_021951

Computer Information (please complete the following!):

  • OS: Arch Linux, KDE Plasma 6.0.3, X11
  • Host: Renoise 3.4.3, Reaper 7.14, standalone
@eigenvoid eigenvoid added the Bug Report Item submitted using the Bug Report template label Apr 10, 2024
@mkruselj
Copy link
Collaborator

mkruselj commented Apr 10, 2024

This is a Renoise thing, we've had a report on this already. Disable Renoise's virtual keyboard or Surge's, you shouldn't have both enabled at the same time.

I cannot get this behavior in standalone.

@eigenvoid
Copy link
Author

eigenvoid commented Apr 10, 2024

Yeah, but it also happens in Reaper, and I just tried in on the Bitwig demo, and it happens there too. So, this issue isn't caused by any particular DAW.

Also, this doesn't happen in other plugins with virtual keyboards, such as Vital.

I just tried the Windows version of Surge in Renoise using yabridge, and it didn't happen there, so I think this might be a Linux issue.

@baconpaul
Copy link
Collaborator

Do you have a non-standard keyboard map or some such?

I wonder if our extended keyboard handling is picking up a key code on arch with your setup.

@eigenvoid
Copy link
Author

The only non-standard keyboard map I have is "English (intl., with AltGr dead keys)"

However, switching to the default "English (US)" doesn't fix it, and actually makes it so that F# gets triggered in addition to E and F.

I also tried it on Wayland, thinking it might be an X11 issue, but it's the same.

@mkruselj
Copy link
Collaborator

Def sounds like Arch related issue.

@erroreyes
Copy link

erroreyes commented Apr 10, 2024

I've been able to reproduce this in the period of 5 minutes of testing. It doesn't happen all the time, but often enough to see it as a problem.

In standalone with Virtual Keyboard on, I switch focus to some random window and then back to Surge XT; 1/3 of the time nothing happens and I can play it with computer keyboard; another 1/3 the F in the current octave is triggered and is stuck when I play the computer keyboard, sometime another F an octave higher is also triggered and held; and the last 1/3 an F and sometimes an F an octave up play and get stuck as soon as I switch focus back to SurgeXT.

This is only tested with v1.3.1.4b53827 standalone, Kubuntu 23.10, Plasma 5.27.8, KWin.

My keyboard is standard using the US layout, and the only thing weird going on is that I turned Caps Lock into a third Ctrl key.

@baconpaul
Copy link
Collaborator

OK great. So sounds like 'something' is wrong with our keyboard handling on linux.

i wonder if its the extended key keyboard mask.

Will add to list!

@mkruselj mkruselj added this to the Surge XT 1.3.3 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Development

No branches or pull requests

4 participants