Keyboard, mouse, and other inputs

[themoeway-bot]

toasted-nutbread opened issue FooSoft/yomichan#267 on 2019-10-26

---

This issue is intended to be an overview of issues features related to inputs. There are some changes I want to make to text-scanning inputs, and I'm going to list all other input-related issues I can find.

Add support for pen devices using pointer events

• Refactor frontend.js to be more simple, easier to understand, and more compatible with the changes that will be necessary for pointer devices. dexie: use blobs obtained from unpkg and update library README #266
• Implement support for pen devices using pointer events on devices which support it. Fix tags not displaying for duplicate cards #819

Customizable scanning modifier keys

• Custom modifiers for searching either terms, kanji, or both. Auxiliary いる able to attach to itself #79, pitch-accent-graphs-jj doesn't show up in drop-down #822
• Modifier keys to prevent scanning and/or close the popup. Are there anyway to style (bold, highlight or underline, etc) the part of the text in the glossary when exporting to Anki. #789, pitch-accent-graphs-jj doesn't show up in drop-down #822

Customizable webpage hotkeys

• Trigger lookup of selected text. Bump github/codeql-action from 2.2.9 to 2.3.5 #161
• Editing existing hotkey mapping & creating new hotkeys. (Firefox) Intuitive UI to grant permissions for websites #127, Bump @playwright/test from 1.31.2 to 1.32.2 #133
• Scan using arrow keys Bump .node-version to v20 (due to EOL of v16) #300

UI changes

• Potentially some tweaks to the organization and labeling of some of the options on the settings page. Bump eslint-plugin-jsonc from 2.4.0 to 2.7.0 #120
• UI for editing and assigning custom keyboard shortcuts.

[themoeway-bot]

siikamiika commented on 2019-12-01

---

Just adding a mention of gestures here as well in addition to https://www.github.com/FooSoft/yomichan/issues/292#issuecomment-560111090

[themoeway-bot]

siikamiika commented on 2019-12-01

---

Another issue: the search page query parser and glossary clicking don't currently support touch events. I could copy and paste code from frontend.js, but that would mean a lot of duplication. Instead, it could be useful to refactor scanning to a new class and use it from frontend.js and other places as needed. Also mentioned in https://www.github.com/FooSoft/yomichan/pull/279#issue-339144238, but Frontend might be too tied to popups for subclassing.

[themoeway-bot]

siikamiika commented on 2019-12-04

---

@toasted-nutbread Are you working on something that would conflict if I extract the scanning functionality from frontend.js or general objections?

[themoeway-bot]

toasted-nutbread commented on 2019-12-04

---

The only thing I've somewhat started on is pointer events, so I don't have anything that should conflict.

[themoeway-bot]

siikamiika commented on 2019-12-07

---

Swipe gestures could work only on some parts of the popup or search page, similar to what's done in https://www.github.com/FooSoft/yomichan/commit/e99c8c40a1b87e307d5365fe619fa1a71996b500 and how Chrome for Android switches between tabs.

[themoeway-bot]

siikamiika commented on 2019-12-10

---

Regarding #300 and #161, I think we could reuse the scanning modifiers but for now give the caret position adjustment responsibility to the browser or another extension. The copy event (https://www.github.com/FooSoft/yomichan/issues/300#issuecomment-563918308) shouldn't focus the popup immediately, but there could be another hotkey for that. Automatically selecting the scanned text might also interfere with the feature.