Fix HTML lang tags not matching the selected language #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/bug
|
The Japanese stroke orders font is still used when displaying character information. Other than that, looks good 👍 |
|
Fixed |
MarvNC
approved these changes
May 20, 2024
jamesmaa
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #974
Fixes #905 (assuming the guy who wanted to be assigned to this issue has disappeared and I'd rather not leave this broken for too long)
Falls back to japanese as the default.
@MarvNC If you could test that this got all the spots where the
jalanguage tags needed to be replaced would be great. I fixed everything I found besides a few things like hardcoded japanese text in a few options and pitch graph annotations.