New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordering Kanji Dictionaries & Collapse doesn't work #953

Open

cristian428 opened this issue May 16, 2024 · 1 comment

Labels

kind/bug

cristian428 commented May 16, 2024

I think this is a bug because we are unable to reorder kanji dictionaries like term dictionaries even if you change the priority number.

Also can't collapse a kanji/hanzi dictionary. Some dictionaries like the Wiktionary one take up way too much space.

よろしくお願いします

cristian428 added the kind/bug label

Member

Kuuuube commented May 20, 2024

Note if anyone decides to pick up this issue: kanji dicts do appear to be sorted https://github.com/themoeway/yomitan/blob/master/ext/js/language/translator.js#L2048-L2071

But due to the way yomitan shows kanji glossaries this sorting doesnt do anything.

It's possible this may require fixing how kanji dicts work in general (#596)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment