You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Upon importing a dictionary with multiple Yomitan settings tabs open in Firefox, the dictionaries in settings will duplicate in the UI. This is purely visual and does not break anything on the backend. Refreshing the page makes this go away.
To Reproduce:
Open multiple settings pages. Easiest way to do this is open the settings page and copy past the url into other tabs.
Import a dictionary
Appears to only affect Firefox. I was unable to reproduce this on Chromium.
This issue is caused by #930 and specifically the order of this logic in ext/js/pages/settings/dictionary-import-controller.js:
However, if these are reversed to revert back to the previous behavior like this, it un-fixes #723, the (much more serious) issue being addressed in #930:
Description
Upon importing a dictionary with multiple Yomitan settings tabs open in Firefox, the dictionaries in settings will duplicate in the UI. This is purely visual and does not break anything on the backend. Refreshing the page makes this go away.
To Reproduce:
Appears to only affect Firefox. I was unable to reproduce this on Chromium.
This issue is caused by #930 and specifically the order of this logic in
ext/js/pages/settings/dictionary-import-controller.js
:However, if these are reversed to revert back to the previous behavior like this, it un-fixes #723, the (much more serious) issue being addressed in #930:
Yomitan version
24.5.14.0
The text was updated successfully, but these errors were encountered: