Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Optimize projection executor to avoid deep copy for no dup column ref #16856

Merged
merged 5 commits into from
May 30, 2024
Merged

executor: Optimize projection executor to avoid deep copy for no dup column ref #16856

merged 5 commits into from
May 30, 2024

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Apr 17, 2024 •
edited

What is changed and how it works?

Issue Number: Close #16858

What's Changed:

Reconginize no-dup column ref only projections, and avoid deep VectorValue copy for such cases.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2024 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2024

Hi @yibin87. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2024

/run-all-tests

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2024

/cc @gengliqi @wshwsh12

@ti-chi-bot ti-chi-bot bot requested review from gengliqi and wshwsh12 April 17, 2024 09:13
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label May 27, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels May 29, 2024
@gengliqi
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 29, 2024

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 29, 2024

This pull request has been accepted and is ready to merge.

Commit hash: d6773ba

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 29, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented May 29, 2024

/cc @windtalker

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 29, 2024

@yibin87: GitHub didn't allow me to request PR reviews from the following users: windtalker.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @windtalker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Fix format issue
41f2c75 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Status: Can merge to base branch label May 30, 2024
@gengliqi
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 41f2c75

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label May 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 290dab1 into tikv:master May 30, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees
No one assigned
Labels
contribution Type: PR - From contributors ok-to-test release-note-none size/L status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

Avoid deep copy inside projection executor
3 participants
@yibin87 @gengliqi @wshwsh12