Dark theme fixes for navbar and dropdown (Fixes #39984) #39989
Conversation
karlshea
changed the title
There was a problem hiding this comment.
Thanks for submitting a PR @karlshea
I haven't looked at the code and the modifications that you suggest yet. However, I can see in the deployed version a rendering issue in the dark mode version of https://deploy-preview-39989--twbs-bootstrap.netlify.app/docs/5.3/components/navbar/#color-schemes, where the last navbar should render black texts instead of white:
|
@julien-deramond I'm not sure how the last navbar could be fixed if the background color is set with a style tag, there doesn't seem to be anything to work off of there? In 5.3 without this PR's change if I remove |
|
I've checked rapidly, but there is a forced I'll need to find the time to check all the existing PRs and issues at the same time regarding the color modes, because this could be also fixed automatically by #39295 if the |
|
Yeah I'm not really sure what to do here. Maybe CSS specificity is winning? |
Description
data-bs-theme="dark"on parent element of.navbarto trigger.navbar-darkvariables as described in the documentation.data-bs-theme="dark"on parent or current element of.dropdown-menuto trigger.dropdown-menu-darkvariables as described in the documentation.Motivation & Context
Closes #39984
Type of changes
Checklist
npm run lint)Live previews
Related issues
#39984, #39291