Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused variable #346

Open
maddin200 opened this issue Nov 22, 2022 · 1 comment
Open

unused variable #346

maddin200 opened this issue Nov 22, 2022 · 1 comment
Labels
bug library Development interface and library

Comments

@maddin200
Copy link

NFIQ2/NFIQ2Algorithm/src/nfiq2/nfiq2_qualityfeatures_impl.cpp line 76
Code:
std::unordered_map<std::string, double>
NFIQ2::QualityFeatures::Impl::getQualityFeatureValues(
const std::vector<std::shared_ptrNFIQ2::QualityFeatures::Module>
&features)
{
std::vectorstd::string qualityIdentifiers =
NFIQ2::QualityFeatures::Impl::getQualityFeatureIDs(); // <- assigned but unused

std::unordered_map<std::string, double> quality {};

for (const auto &feature : features) {
	const auto moduleFeatures = feature->getFeatures();
	quality.insert(moduleFeatures.cbegin(), moduleFeatures.cend());
}

return quality;

}

@maddin200 maddin200 added bug library Development interface and library labels Nov 22, 2022
@gfiumara
Copy link
Member

Thanks. Let's link to #134, which would likely expose this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug library Development interface and library
Projects
None yet
Development

No branches or pull requests

2 participants