Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with 0-threshold trigger algorithm #257

Open
joefowler opened this issue Mar 2, 2022 · 1 comment
Open

Fix problems with 0-threshold trigger algorithm #257

joefowler opened this issue Mar 2, 2022 · 1 comment
Assignees

Comments

@joefowler
Copy link
Member

Jamie at NSLS-II is having weird data problems that seem to imply 0-threshold triggering is not working 100%. See Feb 17 conversations and notes. Will need to look at LJH/OFF data to diagnose. Hope is that the problem is simply one of numerical parameters in the algorithm?

@ggggggggg
Copy link
Collaborator

This is still an issue, we determined that the zero threshold is working, it just not tuned to put the phase correction kink right at the boundary. So we still need to tune the zero threshold algorithm, probably just by tweaking a few numbers.

@ggggggggg ggggggggg reopened this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants