Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unit and integration tests for Task Plugins endpoint according to user stories #316

Open
1 task
keithmanville opened this issue Nov 2, 2023 · 1 comment
Open
1 task

Implement unit and integration tests for Task Plugins endpoint according to user stories #316

keithmanville opened this issue Nov 2, 2023 · 1 comment
Assignees
@andrewhand
Labels
icebox Tabled/archived for now, but may be revisited later on test Additions or changes to project tests
Milestone
November Milestone

Comments

@keithmanville
Copy link
Collaborator

keithmanville commented Nov 2, 2023 •
edited by jkglasbrenner

Implement unit and integration tests for the Task Plugins endpoint according to user stories defined in #284

Follow the integration test pattern from #281

Definition of Done

  • 100% coverage of Task Plugins endpoints

Dependencies

depends on #284
@keithmanville keithmanville mentioned this issue Nov 7, 2023
Closed
1 task
@keithmanville keithmanville added the test Additions or changes to project tests label Nov 7, 2023
@keithmanville keithmanville added this to the November Milestone milestone Nov 14, 2023
andrewhand added a commit that referenced this issue Dec 1, 2023
@andrewhand
tests: added fixtures for task plugin archives
41fdcde 
Used fixtures to pass a tmp dir containing a .tar file to represent a task plugin archive.

Closes #316
andrewhand added a commit that referenced this issue Dec 1, 2023
@andrewhand
tests: removed para to fix error
70d868a 
Left in an old parameter for form request fixtures that needed to be removed.

Closes #316
andrewhand added a commit that referenced this issue Dec 7, 2023
@andrewhand
fix: Fixed task plugin test fixtures.
d329354 
The fixtures need to be update to hold a filename and use the 'data' field for api posts.

Closes #316
@jkglasbrenner jkglasbrenner added the icebox Tabled/archived for now, but may be revisited later on label Dec 19, 2023
@jkglasbrenner
Copy link
Collaborator

Putting this in the icebox for now. The Task Plugins testing proved to be more complicated because of the dependency on MinIO S3. This endpoint is going to change the most in the near future, so we've decided to leave the tests as is, and revisit this once we've implemented the changes.

@alexb1200 alexb1200 mentioned this issue Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewhand andrewhand

Labels
icebox Tabled/archived for now, but may be revisited later on test Additions or changes to project tests
Projects
None yet
Milestone
November Milestone
Development

No branches or pull requests
3 participants
@jkglasbrenner @keithmanville @andrewhand