Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_request_data is writing to location where permission could be denied #251

Open
wd15 opened this issue Aug 29, 2022 · 2 comments
Open

Comments

@wd15
Copy link
Collaborator

wd15 commented Aug 29, 2022

Describe the bug

The function get_request_data writes to a location that the user might not have to permission to write to, https://github.com/usnistgov/jarvis/blob/master/jarvis/db/figshare.py#L284. Better would be to use a temporary directory given by the OS. Writing to the location where the software is installed is not a good idea for a number of reasons including that the areas used for installation should only be written to by the package manager.

@knc6
Copy link
Collaborator

knc6 commented Jan 10, 2023

Thanks for the suggestion. How about using store_dir ?

https://github.com/usnistgov/jarvis/blob/master/jarvis/db/figshare.py#L337

@wd15
Copy link
Collaborator Author

wd15 commented Jan 10, 2023

That's fine. If store_dir is None then maybe use the temporary directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants