Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove the default or null requirement when merges are in-order #302

Open
tantaman opened this issue Aug 2, 2023 · 1 comment

Comments

@tantaman
Copy link
Collaborator

tantaman commented Aug 2, 2023

We only need the constraint that columns must have default values or be nullable if the merge order can be out of order.

For cases where users will be merging changes in-order we can do a two-phase commit against crsql_changes and relax this constraint.

The one extra caveat would be that syncs must be at transaction bounds. This could be problematic for long divergence given we lose some transaction information (see https://vlcn.io/blog/how-crsqlite-transactions-work-today)

So.. maybe back to a second virtual table for "full row" merges?

@tantaman
Copy link
Collaborator Author

tantaman commented Aug 3, 2023

Related to #294 (vtab for full row sync)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant