Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable update_check in API tavern tests #23362

Closed
4 tasks done
Selutario opened this issue May 9, 2024 · 2 comments · Fixed by #23374
Closed
4 tasks done

Disable update_check in API tavern tests #23362

Selutario opened this issue May 9, 2024 · 2 comments · Fixed by #23374
Assignees
Labels
level/subtask type/enhancement New feature or request

Comments

@Selutario
Copy link
Member

Selutario commented May 9, 2024

Description

Similar to what we did in #23247, we must also update the AIT (tavern) so that update_check feature is disabled in all of them.

There is however one exception. The test_manager_endpoints.tavern.yaml makes calls to the GET /manager/version/check endpoint, so update_check should still be enabled in this test. The possibility of mocking the service in any way (for example, using something like https://www.mock-server.com/) must be analyzed.

Checks

The following elements have been updated or reviewed (should also be checked if no modification is required):

  • Tests (unit tests, API integration tests).
  • Changelog.
  • Documentation.
  • Integration test mapping (using api/test/integration/mapping/_test_mapping.py).
@GGP1
Copy link
Member

GGP1 commented May 10, 2024

Update

Set the update check service to disabled by default and created a CTI service mock for specific tests where we want it enabled.

@GGP1 GGP1 linked a pull request May 10, 2024 that will close this issue
@GGP1
Copy link
Member

GGP1 commented May 15, 2024

Update

Resolved a conflict in the test envrionment docker compose file after the base branch was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/subtask type/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants