Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect Popup exceeds window #11044

Closed
1 task
zaaakher opened this issue May 14, 2024 · 5 comments · Fixed by #11081
Closed
1 task

Inspect Popup exceeds window #11044

zaaakher opened this issue May 14, 2024 · 5 comments · Fixed by #11081
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: toolbar Related to dev toolbar (scope)

Comments

@zaaakher
Copy link

Astro Info

Astro                    v4.8.3
Node                     v18.19.0
System                   Windows (x64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             @astrojs/react
                         @astrojs/tailwind
                         @astrojs/partytown

If this issue only occurs in one browser, which browser is a problem?

Chrome

Describe the Bug

When I try the inspect feature the popup exceeds the current window. I'm not sure if this happens because my site is RTL or not
(notice the scrollbar at the bottom is due to the popup)
image

What's the expected result?

It should stay within the window and pop to the left/right depending on conditional awareness of it's position

image

Link to Minimal Reproducible Example

n/a

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label May 14, 2024
@matthewp matthewp added needs repro Issue needs a reproduction and removed needs triage Issue needs to be triaged labels May 14, 2024
Copy link
Contributor

Hello @zaaakher. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.

@matthewp
Copy link
Contributor

Please provide a reproduction. If RTL is the problem then you should be able to reproduce that way, thank you.

@zaaakher
Copy link
Author

My apologies @matthewp, here you go https://stackblitz.com/edit/github-5k1mkz?file=src%2Fpages%2Findex.astro

Here's a quick gif showing it:
astro-rtl-inspector-popup

@bluwy bluwy added - P3: minor bug An edge case that only affects very specific usage (priority) feat: toolbar Related to dev toolbar (scope) and removed needs repro Issue needs a reproduction labels May 15, 2024
@bluwy
Copy link
Member

bluwy commented May 15, 2024

Looks like rtl is messing with the positioning calculation

@V3RON
Copy link
Contributor

V3RON commented May 15, 2024

@bluwy There is a check for right-side overflow, but not for left-side overflow. I'll open a PR adding one shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: toolbar Related to dev toolbar (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants