Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ysync: DefaultProtocol - after doc update, reapply step 1 if pending update was found #431

Open
Horusiath opened this issue May 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Horusiath
Copy link
Collaborator

Horusiath commented May 7, 2024

In general when we get out-of-order or missing update, we should try to restart connection and start from step 1 (sending state vectors). However it's not always easy to detect. We check if after update application, there are still pending updates and depending on that:

  1. Trigger an Err in order to signal missing update. This may be bad if missing update was on the way (however the rule that updates still should arrive in order should apply).
  2. Return SyncStep1 reply that will be send back to the requester.

Eventually we can split that into two, and provide two protocol implementation - one triggering restart via pt.1 another sending sync step back.

@Horusiath Horusiath added the enhancement New feature or request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant