Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: crypto: mbedtls: crypto.mbedtls does not have permission on entropy driver #72747

Merged
merged 1 commit into from
May 15, 2024

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented May 14, 2024

Fixes #72625

- Do not set CONFIG_MBEDTLS_ZEPHYR_ENTROPY in
  tests/crypto/mbedtls because this can cause test failure on
  real devices in which test thread do not have access to
  drivers.
- make MBEDTLS_PSA_CRYPTO_RND_SOURCE depending on
  MBEDTLS_PSA_CRYPTO_C because it only makes sense when the
  latter is defined

Signed-off-by: Valerio Setti <vsetti@baylibre.com>
@valeriosetti
Copy link
Contributor Author

@nordic-piks and @katgiadla this is the fix for the issue you found (#72625 and #72716). I tested it on nrf52840dk and it's OK there. Can you please have a look and double check if this OK also for other boards? I don't have them all, sorry.

@nordic-piks
Copy link
Contributor

@nordic-piks and @katgiadla this is the fix for the issue you found (#72625 and #72716). I tested it on nrf52840dk and it's OK there. Can you please have a look and double check if this OK also for other boards? I don't have them all, sorry.

Checked, the fix works fine for other platforms. Also verified other crypto tests for regression, found none.

Copy link
Collaborator

@frkv frkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlescufi carlescufi added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label May 15, 2024
@carlescufi carlescufi assigned ithinuel and unassigned d3zd3z May 15, 2024
@aescolar aescolar merged commit dfae5ba into zephyrproject-rtos:main May 15, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Crypto / RNG Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crypto: mbedtls: crypto.mbedtls fails
9 participants