Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LE Audio: Rename struct bt_audio_codec_qos #72684

Open
Thalley opened this issue May 13, 2024 · 0 comments
Open

LE Audio: Rename struct bt_audio_codec_qos #72684

Thalley opened this issue May 13, 2024 · 0 comments
Assignees
Labels
area: Bluetooth Audio area: Bluetooth Enhancement Changes/Updates/Additions to existing features

Comments

@Thalley
Copy link
Collaborator

Thalley commented May 13, 2024

Is your enhancement proposal related to a problem? Please describe.
The struct actually has nothing to do with the codec, but rather the QoS of the stream.

Describe the solution you'd like
Rename the and any other uses of the word. This also affects macros like BT_AUDIO_CODEC_QOS_UNFRAMED or enums like bt_audio_codec_qos_framing.

Effectively it should be a search and replace bt_audio_codec_qos->bt_audio_qos.

Describe alternatives you've considered
Given that it is very BAP/stream specific, it may be better to rename to bt_bap_qos, bt_bap_stream_qos or bt_bap_ep_qos.

Additional context
The struct is effectively meant to represent the values necessary for the QoS configure operation in ASCS, but is at the same time used for CIG creation.

@Thalley Thalley added Enhancement Changes/Updates/Additions to existing features area: Bluetooth area: Bluetooth Audio labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Audio area: Bluetooth Enhancement Changes/Updates/Additions to existing features
Projects
Status: To do
Development

No branches or pull requests

1 participant