Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtio: Possibly missed callback when linking #72740

Open
teburd opened this issue May 14, 2024 · 1 comment · May be fixed by #72765
Open

rtio: Possibly missed callback when linking #72740

teburd opened this issue May 14, 2024 · 1 comment · May be fixed by #72765
Assignees
Labels
area: RTIO bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone

Comments

@teburd
Copy link
Collaborator

teburd commented May 14, 2024

Describe the bug
@swift-tk had a question in discord that lead to me believing a bug exists in the current way we do callback ops.

We currently do callback ops only on submit https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/rtio/rtio_executor.c#L65

But not if they are chained from a completion https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/rtio/rtio_executor.c#L164

A test should easily show this to be reproducible when fixing.

Expected behavior
Linked callback ops occur after the ops they are linked to complete

Impact
Out of order operations are possible

@teburd teburd added bug The issue is a bug, or the PR is fixing a bug area: RTIO labels May 14, 2024
@teburd teburd added this to the v3.7.0 milestone May 14, 2024
@teburd teburd self-assigned this May 14, 2024
@aescolar
Copy link
Member

@teburd as you are the maintainer of RTIO, you are probably the best to assign this bug a priority.
Would you be so kind as to do so?

@teburd teburd added priority: medium Medium impact/importance bug labels May 14, 2024
@teburd teburd linked a pull request May 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: RTIO bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants