-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Crash 'ACSException' -> 'Unknown error: RequestCorrelationVector: . ResponseCorrelationVector' when creating a video stream view #1763
Comments
@raosanat can you take a look at this? @Svantulden have you tried using the latest version of the library? |
Not yet, as I didn't see any bug/crashfixes between the newest version and If you have any tips for us on how to more consistently reproduce this issue, based on the exception message, let me know. Or if we can provide anything else to debug this. |
Hi @Svantulden
We didn't add the entry to our release note, sorry for that but there was a few bug fixes and crashes related to stream in the latest 2 releases so it should be worth giving it a try.
From the point of the crash looks like an issue that can be reproduced by adding and removing remote participants with video in the call or the participant on other side turning on-off the camera. It feels like some either stream or view renderer is in unexpected state (more likely stream). Can you share if you dispose the renderer and if you do in which method, and when |
Thanks @lucianopa-msft . I've just now upgraded to the latest version of the SDK (
I've now got a solid reproduction scenario:
See the reproduction scenario above. I suspect the Now that we've got a consistent reproduction scenario, the issue becomes more clear. I've added a check for stream state to be |
@Svantulden, thank you for the detailed info.
Hard to say given that I am not sure which exception that is, but is more likely we didn't raise exception.
Sounds good, this maybe down to attempt to create a view but the stream is in a state (maybe due to dispose) where it will not work, so we raise the error. Your check looks reasonable fix so I think we can close. Thank you :) |
Describe the bug
Our app crashes on a new exception we have since upgrading from
2.3.0
to2.8.0
of the ACS Calling iOS SDK. Our code has a do-catch block around thetry newRenderer.createView(withOptions: CreateViewOptions(scalingMode: scalingMode))
code, however catching anNSException
(which theACSException
is) is impossible within Swift code. So the app crashes.Exception or Stack Trace
Firebase exception description:
Exception trace
To Reproduce
No idea yet. It happens a lot for our calling app in Firebase (it's our most occurring crash at the moment), however it doesn't happen often per user, as the amount of unique users with this crash is equal to the amount of crashes.
Code Snippet
Expected behavior
No crash.
Setup (please complete the following information):
2.8.0
Additional context
The code is called both when joining a call (initialising the stream after the first participant joined and
didUpdateVideoStreams
is called) and when the calldidChangeState
to.connected
when there are already participants available in the call.Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
The text was updated successfully, but these errors were encountered: