Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST Fuzzer triggered stack overflow for 02896_cyclic_aliases_crash #64065

Closed
qoega opened this issue May 17, 2024 · 1 comment · Fixed by #64082
Closed

AST Fuzzer triggered stack overflow for 02896_cyclic_aliases_crash #64065

qoega opened this issue May 17, 2024 · 1 comment · Fixed by #64082
Assignees
@alexey-milovidov
Labels
fuzz Problem found by one of the fuzzers

Comments

@qoega
Copy link
Member

qoega commented May 17, 2024

https://s3.amazonaws.com/clickhouse-test-reports/0/c1f853d92a2f613fccc72ace81574b7f413c0e7b/ast_fuzzer__debug_.html

Based on 02896_cyclic_aliases_crash.sql

2024.05.14 12:42:04.867506 [ 173 ] {0dc930af-4b10-4c3a-8ca2-0fdc5fe1b998} <Debug> executeQuery: (from [::ffff:127.0.0.1]:39696) (comment: /workspace/ch/t
ests/queries/0_stateless/02896_cyclic_aliases_crash.sql) EXPLAIN SYNTAX SELECT val, val + 1 AS prev, val + prev AS val FROM (SELECT 1 AS val) (stage: Complete)

EXPLAIN SYNTAX
SELECT
    val,
    val + 1 AS prev,
    val + prev AS val
FROM
(
    SELECT 1 AS val
)

Without some random settings it just fails with TOO_DEEP_AST / Normalized AST is too deep
https://fiddle.clickhouse.com/0e8af3b6-2cf0-4c5c-80ae-612bf72ea5d5
@qoega qoega added the fuzz Problem found by one of the fuzzers label May 17, 2024
@alexey-milovidov
Copy link
Member

SET max_ast_depth = 10000000 - should be blocked in Fuzzer.

@alexey-milovidov alexey-milovidov self-assigned this May 18, 2024
@alexey-milovidov alexey-milovidov mentioned this issue May 18, 2024
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexey-milovidov alexey-milovidov

Labels
fuzz Problem found by one of the fuzzers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent stack overflow in Fuzzer and Stress test ClickHouse/ClickHouse
2 participants
@qoega @alexey-milovidov