Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does it not support array? #11

Open
li-bit opened this issue May 5, 2019 · 7 comments
Open

does it not support array? #11

li-bit opened this issue May 5, 2019 · 7 comments
Labels

Comments

@li-bit
Copy link

li-bit commented May 5, 2019

[Ljava.lang.String;@3fbd63e5

@enqueue
Copy link
Contributor

enqueue commented May 6, 2019

Right now, arrays are not supported. I will try to get this working, but it needs some tweaking of the underlying JDBC driver as well, see for example ClickHouse/clickhouse-java#300

What would you expect from array support in MetaBase? Simply display a comma-separated String?

@li-bit
Copy link
Author

li-bit commented May 6, 2019

I want to use func of array,such as uniqArray

@StephenSorriaux
Copy link

Hi,

Thanks for this great plugin. Since the new version of the JDBC driver that includes your PR, do you think it would be possible to enhance the display of Arrays?

@enqueue
Copy link
Contributor

enqueue commented Jun 18, 2019

I think I'll still have to override ClickHouseArray.toString(). That's at least how it works for the Postgresql driver.

enqueue added a commit that referenced this issue Jun 21, 2019
@enqueue enqueue mentioned this issue Jun 21, 2019
enqueue added a commit that referenced this issue Jun 21, 2019
@enqueue
Copy link
Contributor

enqueue commented Jun 21, 2019

I added a String representation for arrays in the driver code, so you should at least be able see your Array data. Please check out the current master or download version 0.3 from the "Releases" page.

I am looking forward to hearing about your experiences. Have a great weekend! 👋

Screenshot_20190621_213806

@StephenSorriaux
Copy link

@enqueue Thanks a lot, it is working perfectly well!

Do you think it would be hard to had some "basic" filtering on it (check if element is in array, for instance)?

@enqueue
Copy link
Contributor

enqueue commented Jun 24, 2019

As far as I can see, there is currently no explicit filtering support for array contents in Metabase (see e.g. [metabase/metabase#2974]). We could try and hack something in the driver, but that would not be a sustainable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants