Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking on streamed audio #105

Open
E-Kuerschner opened this issue Apr 21, 2023 · 3 comments
Open

Seeking on streamed audio #105

E-Kuerschner opened this issue Apr 21, 2023 · 3 comments
Assignees

Comments

@E-Kuerschner
Copy link
Owner

Describe the bug
There may be an issue when attempting to seek on live, streamed audio.

To Reproduce
Steps to reproduce the behavior:

  1. run examples (yarn start in ./exampes)
  2. go to Basic Example and choose the live audio from the sound source drop down
  3. hit play
  4. click forward in the time bar

There will be an error. The seek function is being passed the value of Infinity.

Expected behavior
Im not sure what the expected behavior should be. Maybe seeking should be disabled while streaming if we can detect that case.

Environment (please complete the following information):

  • Browser/ browser version:
  • Library version:
  • React version:
  • Node version:
@E-Kuerschner E-Kuerschner self-assigned this Apr 21, 2023
@brianshano
Copy link
Contributor

For streaming live radio, skip forward wouldn't be possible and I wouldn't expect to be able to skip backwards either.
Any other streamed audio that might have a case for skipping forward or backward?

@phemartin
Copy link

phemartin commented Aug 2, 2023

@E-Kuerschner I'd expect to wait for the file to load and play it then.

@brianshano Any podcast player that fetches audio via streaming.

@E-Kuerschner
Copy link
Owner Author

@phemartin the audio in this case cannot be downloaded to completion. Internet radio streams would be an example of something that cannot (and should not) be seeked.

Im considering just disabling the seek functionality when the duration is Infinity (which is the value for audio like this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants