Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Machine Status in Cloud Review Notifications #417

Open
er4z0r opened this issue Apr 11, 2024 · 2 comments
Open

List Machine Status in Cloud Review Notifications #417

er4z0r opened this issue Apr 11, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@er4z0r
Copy link

er4z0r commented Apr 11, 2024

Is your feature request related to a problem? Please describe.
As a user reading the slack notifications from the Cloud Review task I'd like to see if any of the listed cloud instances is in a running or shut down state.

Describe the solution you'd like
Add a 'State' field to the slack message showing "Running" or "Shut down".

Describe alternatives you've considered
Manually checking the state. Extra effort that kinda negates the usefulness of the "Cloud Review" task.

Additional context
It puts me in a more informed position when arguing with whomever created the instance. With the way things currently are I always have to check the control panel of $cloudprovider before heckling my colleagues about having left an instance running.

@chrismaddalena chrismaddalena self-assigned this Apr 11, 2024
@chrismaddalena
Copy link
Collaborator

That would be a simple change. The task already tracks the state by name (e.g., running, shutting-down). The task does default to returning only instances that are still running, so most states would show "Running" in the message. However, there are arguments (aws_only_running and do_only_running) to check all instances, even those shut down, so there are cases where you might have non-running instances returned.

I've added an Instance State block to the Slack messages for teardown and untracked notifications. It'll be in the next release from the v4-1-dev branch.

@chrismaddalena chrismaddalena added this to the v4.1.1 milestone Apr 17, 2024
Copy link

github-actions bot commented Jun 1, 2024

This issue has been labeled as stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

2 participants