Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.10: MPP with JS but without WASM target: Cannot determine the version of Skiko for Compose '1.6.10 #4834

Closed
hfhbd opened this issue May 18, 2024 · 5 comments
Assignees
Labels
bug Something isn't working wait for reply Further information is requested web

Comments

@hfhbd
Copy link
Contributor

hfhbd commented May 18, 2024

Describe the bug
I use a MPP module with JS (compose html) but without WASM but the Gradle plugin tries to add the wasm dependency which fails due the missing target.

Affected platforms

  • Web (K/JS) - HTML library

Versions

  • Libraries:

    • Compose Multiplatform version: 1.6.10
  • Kotlin version: 2.0.0-RC3

To Reproduce
Steps to reproduce the behavior:
Bump a K/JS compose html project from 1.6.10-rc03 to 1.6.10
https://github.com/hfhbd/ComposeTodo/actions/runs/9138327814/job/25129335777?pr=981

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
https://gradle.com/s/nsucmftltej5a

@hfhbd hfhbd added bug Something isn't working submitted labels May 18, 2024
@eymar
Copy link
Collaborator

eymar commented May 21, 2024

@hfhbd I see another attempt passed: https://github.com/hfhbd/ComposeTodo/pull/985/files Is there still a problem?

Tried in our compose.html (k/js) example, and it worked. I'll try with your project too.

@hfhbd
Copy link
Contributor Author

hfhbd commented May 21, 2024

@eymar Well, I removed the JetBrains Compose plugin for the html modules and added the runtime dependency manually to not be blocked.

@eymar
Copy link
Collaborator

eymar commented May 21, 2024

I see. Thanks for clarification

@eymar
Copy link
Collaborator

eymar commented May 21, 2024

Do you mean you did this change - hfhbd/ComposeTodo#984?
Is it supposed to fail on this commit (+ version update) hfhbd/ComposeTodo@73b14f5 ?

I did the following:

  • Checked out hfhbd/ComposeTodo@73b14f5
  • Updated the version from 1.6.10-rc03 to 1.6.10 in libs.versions.toml
  • Synced the project - no issues
  • ./gradlew clean :web:jsBrowserRun - works fine.

Am I missing something?

@eymar eymar added web wait for reply Further information is requested and removed submitted labels May 21, 2024
@eymar eymar self-assigned this May 21, 2024
@eymar
Copy link
Collaborator

eymar commented May 21, 2024

Perhaps it was caused by the timing: compose-multiplatform-plugin became available and the bot decided to update right away. But the artefacts (compose libs) were not available yet in mavenCentral at that moment.

Feel free to reopen, if you have any more details or if you disagree.

@eymar eymar closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wait for reply Further information is requested web
Projects
None yet
Development

No branches or pull requests

2 participants